Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: ToggleGroup icon and label-props replacing children. #2929

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented May 15, 2024

Description

Resolves #2898

Resolves nr 1 here: #391

Change summary

  • Added a new icon and label-prop for ToggleGroup (reflecting Tab-implementation)
  • Added conditional-types for either one of icon/label, children, but not both at the same time
  • Marked children as @deprecated

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 04057c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor
@navikt/aksel Minor
@navikt/aksel-stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 15, 2024

Storybook demo

fcafa3141 | 64 komponenter | 165 stories

@KenAJoh KenAJoh enabled auto-merge (squash) May 15, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Innspill til komponent]: <ToggleGroup.Item />
1 participant