Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New icons for geometric shapes #2927

Merged
merged 8 commits into from
May 27, 2024
Merged

feat: New icons for geometric shapes #2927

merged 8 commits into from
May 27, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented May 15, 2024

Resolves #2658

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 6e08114

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/aksel-icons Minor
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel Minor
@navikt/aksel-stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 15, 2024

Storybook demo

Endringer til review: 2

04847bc18 | 64 komponenter | 165 stories

@KenAJoh KenAJoh enabled auto-merge (squash) May 15, 2024 13:32
@navikt/aksel-icons/icons/BookmarkDash.yml Outdated Show resolved Hide resolved
@navikt/aksel-icons/icons/CheckmarkCircleFill.svg Outdated Show resolved Hide resolved
@navikt/aksel-icons/icons/Circle.yml Outdated Show resolved Hide resolved
@sjur-gr
Copy link
Contributor

sjur-gr commented May 16, 2024 via email

@HalvorHaugan
Copy link
Contributor

HalvorHaugan commented May 16, 2024

Nope. Is it bigger than 24x24px? All I did was outline a stroke. 🤘 Sjur

Sorry, I was not being clear. It's still 24x24px, but it has less padding:
image
I find it a bit strange since the other status icons do not have this difference.

@sjur-gr
Copy link
Contributor

sjur-gr commented May 21, 2024

Good catch. Fixed now @HalvorHaugan

@KenAJoh KenAJoh merged commit 1f3df8a into main May 27, 2024
2 checks passed
@KenAJoh KenAJoh deleted the update-icons-1505 branch May 27, 2024 09:16
@github-actions github-actions bot mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nye ikoner]: Geometriske former, stiplet bokmerke og huskelapp-ikon(er)
3 participants