Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

Upgrade marked dependency #15

Closed
netil opened this issue Jan 5, 2018 · 4 comments
Closed

Upgrade marked dependency #15

netil opened this issue Jan 5, 2018 · 4 comments

Comments

@netil
Copy link
Member

netil commented Jan 5, 2018

There's a warning of the security vulnerability.
Update marked to the latest v0.3.9.

image

netil added a commit to netil/egjs-jsdoc-template that referenced this issue Jan 5, 2018
@netil
Copy link
Member Author

netil commented Jan 5, 2018

jsdoc 3.5.5 should be changed also.

@jongmoon
Copy link

jongmoon commented Jan 6, 2018

After applying your commit and doing npm istall. I found marked version is updated to 0.3.9 although I didn't updated jsdoc version.

image

Anyway, jsdoc is currently referenced by grunt-jsdoc not by directly. But grunt-jsdoc version is updated from '1.1.0' (egjs-jsdoc-template) to '2.2.1'(latest grunt-jsdoc) which apply marked 0.3.9 version also. After checking no problem I'll apply latest version.

@jongmoon
Copy link

jongmoon commented Jan 6, 2018

grunt-jsdoc 1.1.0 (egjs-jsdoc-template currently use) has caret ranges for jsdoc like follow.

"dependencies": {
    "jsdoc": "^3.4.0"
  },

So It does not need to update to grunt-jsdoc 2.2.1. because it will update jsdoc to latest if doing npm i

It looks to be possible to apply marked version to 0.3.9 regardless of jsdoc's marked dependency.

jongmoon pushed a commit that referenced this issue Jan 6, 2018
@jongmoon
Copy link

jongmoon commented Jan 8, 2018

Despite of this patch, security warning was not solved (in my case.)

Because each egjs project have dependency on jsdoc, so... after npm installed, jsdoc still depends on marked 0.3.7.

So I think each proejct needs to specify marked version 0.3.9 unless jsdoc patches this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants