Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-page variable use doesn't work when parsed to PDF #3435

Open
5e-Cleric opened this issue Apr 27, 2024 · 2 comments
Open

Multi-page variable use doesn't work when parsed to PDF #3435

5e-Cleric opened this issue Apr 27, 2024 · 2 comments
Labels
bug We say this works but it doesn't P1 - high priority Obvious bug or popular features

Comments

@5e-Cleric
Copy link
Member

5e-Cleric commented Apr 27, 2024 •
edited

Here i describe two variable bugs reported by @TheDungeonMathster in the Discord Of Many Things:

1. Variables with definition lists defined inside them break html comments see #3436

2. Multi-page variable use doesn't work when parsed to PDF

This code works fine in the brew but fails in the PDF render

[foo]:bar

$[foo]

\page

$[foo]
@5e-Cleric 5e-Cleric added bug We say this works but it doesn't P1 - high priority Obvious bug or popular features labels Apr 27, 2024
@G-Ambatte
Copy link
Collaborator

On 2... dammit. I just looked at PrintPage and realized that it effectively uses a copy/paste of the BrewRenderer code, so all of the changes and updates that were made to make variables work across pages just did not get applied to the Print output.
I suspect the best way to fix it will be to extract those functions from the BrewRenderer to a separate component that can then also be accessed from PrintPage, so that the functions only exist in one place and any future changes effect both renders.

@ericscheid
Copy link
Collaborator

This issue needs to be split into two unrelated issues, because the first thing has nothing to do with variables.

image

@ericscheid ericscheid mentioned this issue Apr 28, 2024
Open
@G-Ambatte G-Ambatte mentioned this issue May 9, 2024
Closed
G-Ambatte added a commit to G-Ambatte/homebrewery that referenced this issue May 16, 2024
@G-Ambatte
Merge branch 'master' into fixVariablesInPrint-naturalcrit#3435
cb34054
@5e-Cleric 5e-Cleric changed the title Variables bugs Multi-page variable use doesn't work when parsed to PDF May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug We say this works but it doesn't P1 - high priority Obvious bug or popular features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify PrintPage to use new BrewRenderer methods G-Ambatte/homebrewery
3 participants
@ericscheid @G-Ambatte @5e-Cleric