Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Brew to PDF #3190

Open
5e-Cleric opened this issue Dec 15, 2023 · 9 comments · May be fixed by #3252
Open

[FEATURE]: Brew to PDF #3190

5e-Cleric opened this issue Dec 15, 2023 · 9 comments · May be fixed by #3252

Comments

@5e-Cleric
Copy link
Member

5e-Cleric commented Dec 15, 2023

Feature description

Because browser print to PDF has a number of problems and incompatibilities with our documents, there has been talk about making our own system to export brews as PDFs

Open Issues this feature could potentially resolve:

#2716
#2312
#2278
#1311
#751
#407

Minimum Viable Product

As a minimum, this feature should include the following list of capabilities:

  • Features included in the system dialog print:
    • Choose which pages to print
    • Layout(portrait/landscape)
    • Paper size
    • Pages per sheet
    • Margins
    • Scale
  • Possible new features:
    • Create/keep bookmarks
    • Embed HTML hyperlinks
    • Optimize images
    • Color/B&W option

If you have any idea related to this, or that we should add to the MVP, comment in this issue.

@lucastucious
Copy link
Contributor

I like to choose color/black and white when I print to pdf !

@5e-Cleric 5e-Cleric changed the title Feature: Brew to PDF [FEATURE]: Brew to PDF Jan 16, 2024
@lucastucious
Copy link
Contributor

Another thing is struggle to have is the dpi resolution. I don't know why, but some pdf printer downscale everything to 76dpi. I use homebrewery to print things for print, so a nice 300dpi is mandatory.

@5e-Cleric
Copy link
Member Author

AFAIK dpi will depend on the printer, but we will try to achieve a dpi setting if we can.

@dbolack-ab dbolack-ab self-assigned this Mar 5, 2024
@dbolack-ab
Copy link
Collaborator

dbolack-ab commented Mar 5, 2024

I think we need to add the following to the feature list.

  • Print on Demand ready - Typically this means PDF output in PDF/X-1a:2001 or PDF/X-3:2002.

This is the requirement for DriveThruRPG and is essentially a passthrough for Lightning Source specs.

@calculuschild
Copy link
Member

calculuschild commented Mar 5, 2024

Note that "Embed HTML hyperlinks" and "Color/B&W option" are already built-in to the basic Chrome print.

InternalLinks.mp4

image

@Gazook89
Copy link
Collaborator

Gazook89 commented Mar 5, 2024

I think we need to add the following to the feature list.

Print on Demand ready - Typically this means PDF output in PDF/X-1a:2001 or PDF/X-3:2002.

This is the requirement for DriveThruRPG and is essentially a passthrough for Lightning Source specs.

Here is the list of DTRPG requirements for Print on Demand..

(I may come back to this comment to add print requirements of other PoD services, but can't right now)

@5e-Cleric 5e-Cleric linked a pull request Mar 6, 2024 that will close this issue
@5e-Cleric
Copy link
Member Author

Related, this are the normal options to convert a word to pdf, using adobe acrobat:
image
We could consider saving code comments as pdf comments?

@ericscheid
Copy link
Collaborator

I use code comments <!-- comment -→ for temporarily (?) disabling content. (and more sensible reasons).

Having those comments appear in the PDF would be confusing. If done, this needs to be optional.

@5e-Cleric
Copy link
Member Author

Perhaps this snippet could help?

{{PDFComment
Lorem ipsum dolor sit amet.
}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants