fatal error: runtime: out of memory

[6ecuk]

Unfortunately, the binary carrier is not safe and in the case when you have produced a message without tracing injection was handled by a subscriber with tracer extractor you can catch fatal error: runtime: out of memory.
Related issue: jaegertracing/jaeger-client-go#321
Example:

#Producer
nc.Publish("test", []byte(`"user_id":"49e3c5bb-9c84-4222-9650-30bdde4649a8"`)

#Subscriber
t := not.NewTraceMsg(msg)

// Extract the span context from the request message.
sc, err := tracer.Extract(opentracing.Binary, t)
if err != nil {
    log.Printf("Extract error: %v", err)
}

https://github.com/jaegertracing/jaeger-client-go/blob/ef8f5edb71dffedf02a69593a23bb2fae4e16dc4/propagation.go#L244

[6ecuk]

Generic header support may fix these issues. We can split spanID and payload between headers and body.
nats-io/nats.go#560

[derekcollison]

We are about to land official header support.

[derekcollison]

Also, is this a jaeger client issue or this client library?

[6ecuk]

It's the jaeger client issue

[derekcollison]

Can we post an issue over there as well?

[6ecuk]

There exist the issue jaegertracing/jaeger-client-go#321

[derekcollison]

Perfect thanks.

[6ecuk]

@derekcollison Is there any due of new(tag) version of NATS with the headers support?

[derekcollison]

We are still working through any issues but could tag one if needed. Or do you mean do a release?

[6ecuk]

@derekcollison I waiting for the release to run a stable version on our stage env

[derekcollison]

ok but we do not have a released server that supports it, only nightly builds etc.

[6ecuk]

@derekcollison is nats streaming server will be support headers too?

[derekcollison]

We do not have plans at this time. @kozlovic will make final call though. We do support them in JetStream.

[kozlovic]

No plan, but if they are to be supported by the streaming layer, should headers then not be part of the protobuf itself? But doing so, is different than having them at the core NATS layer, so not sure that applies to this issue.

[6ecuk]

jaegertracing/jaeger-client-go#529 fixed the problem