unsubscribe with limit is missing on reconnect possibly, once the limit is hit too

[matthiashanel]

in go, on reconnect, a subscription with a limit is followed up by unsubscribe(max-received)
This can cause unnecessary traffic and unnecessarily dropped messages in queue subscribers.

nats.java/src/main/java/io/nats/client/impl/NatsDispatcher.java

Lines 163 to 170 in 7f7fe82

	void resendSubscriptions() {
	this.subscriptionsUsingDefaultHandler.forEach((id, sub)->{
	this.connection.sendSubscriptionMessage(sub.getSID(), sub.getSubject(), sub.getQueueName(), true);
	});
	this.subscriptionsWithHandlers.forEach((sid, sub)->{
	this.connection.sendSubscriptionMessage(sub.getSID(), sub.getSubject(), sub.getQueueName(), true);
	});
	}

in Go:
https://github.com/nats-io/nats.go/blob/93a68d7e795f11c0aa30cfa38cf9a4702ae8d8b7/nats.go#L3591

This issue may be worse as, when the limit is actually hit no unsubscribe seems to occur.
These two methods call invalidate
NatsDispatcher.run() (io.nats.client.impl)
NatsSubscription.nextMessage(Duration) (io.nats.client.impl)

which does not seem to have unsubscribe in it's path. (sub.invalidate() does not either)

    void invalidate(NatsSubscription sub) {
        CharSequence sid = sub.getSID();

        subscribers.remove(sid);

        if (sub.getNatsDispatcher() != null) {
            sub.getNatsDispatcher().remove(sub);
        }

        sub.invalidate();
    }