Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetstream.PublishMsgAsync ignores jetstream.WithRetryAttempts and jetstream.WithRetryWait options #1462

Closed
kung-foo opened this issue Nov 6, 2023 · 0 comments · Fixed by #1464
Assignees
Labels
defect Suspected defect such as a bug or regression

Comments

@kung-foo
Copy link

kung-foo commented Nov 6, 2023

Observed behavior

Both jetstream.PublishMsgAsync and jetstream.PublishMsg accept jetstream.WithRetryAttempts and jetstream.WithRetryWait options. But PublishMsgAsync silently ignores them.

This is slightly related to #1461. Our code expects to use PublishMsgAsync to continuously publish messages to a durable stream. One error path is where the stream is not yet configured or is not sized correctly (e.g. NGS limits exceeded). In that case, the (attempted) solution was to allow for a certain number of retries with backoff. But as seen in #1461, the ErrNoStreamResponse is not reliable, but additionally, the retry/wait logic doesn't work either.

Expected behavior

jetstream.PublishMsgAsync to handle retries and waits.

Server and client version

client: v1.31.0
server: v2.10.3

Host environment

No response

Steps to reproduce

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants