Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] Getters for connection callbacks #1162

Merged
merged 1 commit into from Dec 14, 2022
Merged

[ADDED] Getters for connection callbacks #1162

merged 1 commit into from Dec 14, 2022

Conversation

piotrpio
Copy link
Collaborator

This is required when attempting to safely modify existing callbacks from a different package.

@coveralls
Copy link

coveralls commented Dec 14, 2022 •
edited

Coverage Status

Coverage decreased (-0.3%) to 85.499% when pulling 9aba17e on add-handler-getters into 6c6add8 on main.

derekcollison
derekcollison approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wallyqs
wallyqs approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit 95a7e50 into main Dec 14, 2022
@piotrpio piotrpio deleted the add-handler-getters branch December 14, 2022 17:44
@piotrpio piotrpio mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@derekcollison derekcollison derekcollison approved these changes

@Jarema Jarema Awaiting requested review from Jarema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@piotrpio @coveralls @wallyqs @derekcollison