Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated usage of "io/ioutil" #1150

Merged

Conversation

cesarvspr
Copy link
Contributor

No description provided.

@cesarvspr
Copy link
Contributor Author

closes #1149

@coveralls
Copy link

coveralls commented Dec 1, 2022

Coverage Status

Coverage decreased (-0.02%) to 85.869% when pulling 1330d4c on cesarvspr:Replace-deprecated-calls-to-io/ioutil#1149 into 907b219 on nats-io:main.

go.mod Outdated
@@ -3,6 +3,9 @@ module github.com/nats-io/nats.go
go 1.16

require (
github.com/golang/protobuf v1.5.2
github.com/nats-io/nats-server/v2 v2.9.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cesarvspr for the PR! You can avoid changing both go.mod and go.sum by running the tests as follows:

go test -modfile=go_test.mod ./...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thanks! Any idea why tests are intermittent on the pipeline? @wallyqs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it was just a flaky test.

Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! As per @wallyqs comment, please clean up go.mod and go.sum (they should not contain test-only dependencies), then LGTM 👍

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the contribution.

Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit 7ca331a into nats-io:main Dec 5, 2022
@piotrpio piotrpio mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants