Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] ConnectHandler invoked on initial successful connect #1133

Merged
merged 1 commit into from Nov 15, 2022
Merged

[ADDED] ConnectHandler invoked on initial successful connect #1133

merged 1 commit into from Nov 15, 2022

Conversation

piotrpio
Copy link
Collaborator

Resolves #1124

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 85.769% when pulling 2ae0c58 on connect-handler into 5c57d4b on main.

derekcollison
derekcollison reviewed Nov 15, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we ensure it's only called for the very first connect?

@piotrpio
Copy link
Collaborator Author

@derekcollison it's only invoked in Connect() method, which as far as I know is not used anywhere (only exposed as public)

derekcollison
derekcollison approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wallyqs
wallyqs approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit 1cc4427 into main Nov 15, 2022
@piotrpio piotrpio deleted the connect-handler branch November 15, 2022 23:18
@piotrpio piotrpio mentioned this pull request Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add connect handler
4 participants
@piotrpio @coveralls @wallyqs @derekcollison