Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BindStream for watcher so it works with mirrors. #1116

Merged
merged 1 commit into from Nov 1, 2022
Merged

Use BindStream for watcher so it works with mirrors. #1116

merged 1 commit into from Nov 1, 2022

Conversation

derekcollison
Copy link
Member

Updated so connecting to mirror would allow watchers to work.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Use BindStream for watcher so it works with mirrors.
416c895 
Signed-off-by: Derek Collison <derek@nats.io>
kozlovic
kozlovic approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That's what I had to do in the C client...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.834% when pulling 416c895 on kv-mirror-watcher into 48285d7 on main.

@derekcollison derekcollison merged commit e227e17 into main Nov 1, 2022
@piotrpio piotrpio deleted the kv-mirror-watcher branch November 2, 2022 08:08
aricart
aricart reviewed Nov 2, 2022
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio mentioned this pull request Nov 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart aricart left review comments

@kozlovic kozlovic kozlovic approved these changes

@piotrpio piotrpio Awaiting requested review from piotrpio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@derekcollison @coveralls @aricart @kozlovic