Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OK message #133

Open
lubien opened this issue Sep 29, 2022 · 2 comments
Open

Support OK message #133

lubien opened this issue Sep 29, 2022 · 2 comments

Comments

@lubien
Copy link

lubien commented Sep 29, 2022

From spec https://docs.nats.io/reference/reference-protocols/nats-protocol#protocol-messages

I've had to do a quick hack to support logs from Fly.io so maybe this is a good thing to add here too?

Would be glad to follow up with a PR

@mmmries
Copy link
Collaborator

mmmries commented Sep 30, 2022

A quick PR to support this message would greatly appreciated. I've never run this client against a nats server in verbose mode, but if that is useful to your use-case I can see how it would be useful for the whole community. Maybe we add a test where we start a nats server in verbose mode? That way we can make sure this functionality stays supported?

@lubien
Copy link
Author

lubien commented Oct 6, 2022

Sure, I can take a stab at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants