Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept user enforced auth #135

Closed
wants to merge 1 commit into from
Closed

Conversation

lubien
Copy link

@lubien lubien commented Oct 6, 2022

Close #132

Copy link
Collaborator

@mmmries mmmries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reading over this PR again and I think I like your change as it is. It might make most sense to follow the convention of the go code where the client always sends authentication when it has been configured, but that would be a change in the existing behavior, whereas this PR introduces a new flag, so we can safely release this as a minor version release.

What do you think? Should we merge this as-it-is (maybe I'll add a few lines of documentation around it), or should we follow the convention in the go client and always send any auth parameters that have been configured by the client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let nats client send auth_required without waiting for the server to ask for it
2 participants