Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inbox optional #131

Open
lubien opened this issue Sep 29, 2022 · 2 comments
Open

Make inbox optional #131

lubien opened this issue Sep 29, 2022 · 2 comments

Comments

@lubien
Copy link

lubien commented Sep 29, 2022

Hi there!

I've been using a fork of your library on Fly.io for logs for a while but I had to make a few changes.

My proposal here would be to make inbox optional defaulting to true (the current behavior). I've already had this implemented here: 162cd94

If it's something you'd like I could make a pull request and add tests if needed

@mmmries
Copy link
Collaborator

mmmries commented Sep 30, 2022

Hi @lubien I'm glad that the library has been useful! Can you provide a bit more context about why skipping the inbox is useful for the work you're doing? My thought was that creating an inbox is relatively cheap (you could have hundred or thousands of clients each with their own inbox without any noticeable load) and it will only be used if the client decides to do a request/reply.

Are you seeing performance problems with having the client create an inbox even if you don't intend to use it?

@lubien
Copy link
Author

lubien commented Oct 6, 2022

Rather than performance, our use case doesn't really needs it and doesn't support those. We just use NATs for one way messages passing the logs so for us having this inbox broke the usage of this lib so we ended up forking and making this optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants