Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add implementation for consumer replica change #3293

Merged
merged 2 commits into from Jul 27, 2022
Merged

add implementation for consumer replica change #3293

merged 2 commits into from Jul 27, 2022

Conversation

matthiashanel
Copy link
Contributor

fixes #3262

also check peer list on every update

Signed-off-by: Matthias Hanel mh@synadia.com

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current main (git pull --rebase origin main)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Resolves #

Changes proposed in this pull request:

/cc @nats-io/core

@matthiashanel
add implementation for consumer replica change
f926264 
fixes #3262

also check peer list on every update

Signed-off-by: Matthias Hanel <mh@synadia.com>
derekcollison
derekcollison approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - One nit on errors but not a blocker.

server/jetstream_cluster.go Show resolved Hide resolved
@matthiashanel
switch to error vars
e599585 
Signed-off-by: Matthias Hanel <mh@synadia.com>
derekcollison
derekcollison approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthiashanel matthiashanel merged commit 3358205 into main Jul 27, 2022
@matthiashanel matthiashanel deleted the consumer-replica-change branch July 27, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@kozlovic kozlovic Awaiting requested review from kozlovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JetStream - Updating consumer from R3 to R1 doesn't work
2 participants
@matthiashanel @derekcollison