Allow filtered stream mirrors #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
requested review from
ripienaar,
aricart,
kozlovic and
matthiashanel
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
filtered_mirrors
branch
from
3e12a5e
to
a77d594
Compare
kozlovic
requested changes
Jun 29, 2022
There was a problem hiding this comment.
I think we had issues with mirrors and de-dup windows, so not sure why check is removed in this PR. Maybe @ripienaar or @matthiashanel remember better than I do..
derekcollison
force-pushed
the
filtered_mirrors
branch
from
811c995
to
a77d594
Compare
kozlovic
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was allowed before but did not actually assign the filter subject so did not really work. This re-allows it and makes sure it works properly.
Tests are a tad flaky atm but not due to this.
Signed-off-by: Derek Collison derek@nats.io
Resolves #3226
/cc @nats-io/core