Allow stream placement by tags. #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
requested review from
ripienaar,
kozlovic,
matthiashanel and
davidkemper
kozlovic
reviewed
Feb 16, 2022
| @@ -286,7 +286,7 @@ type Options struct { | |||
| ReconnectErrorReports int | |||
|
|
|||
| // Tags describing the server. They will be included in varz | |||
| // and used as a filter criteria for some system requests | |||
| // and used as a filter criteria for some system requests. | |||
There was a problem hiding this comment.
Wonder if user embeds NATS Server and "cast" a simple string slice (with content with upper-case, etc..) to the Options.Tags. I guess that would break. This would be a user error, definitively. They should be using TagList.Add().
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
tag_placement
branch
from
ba3d484
to
ca1132a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core