Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed Authentication Opt-out #170

Open
3 of 11 tasks
aricart opened this issue Nov 18, 2022 · 3 comments
Open
3 of 11 tasks

Failed Authentication Opt-out #170

aricart opened this issue Nov 18, 2022 · 3 comments
Assignees
Labels
client Client related work enhancement New feature or request

Comments

@aricart
Copy link
Member

aricart commented Nov 18, 2022

Overview

Traditionally clients have aborted reconnect reattempts after 2 consecutive authentication errors.
nats-io/nats.go#499

In some setups this behavior creates a different problem because a configuration mistake on the server will stop thousands of clients.

Provide a connect option ignoreAuthErrorAbort that prevents the 2 consecutive errors from aborting the reconnect attempts.
See nats-io/nats.deno@cf2b33c - javascript client changes to fix this.

Clients and Tools

Other Tasks

  • docs.nats.io updated @jnmoyne
  • Update ADR to Implemented
  • Update client features spreadsheet

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

@aricart aricart added enhancement New feature or request client Client related work labels Nov 18, 2022
@bruth
Copy link
Member

bruth commented Nov 21, 2022

@aricart No urgency, but is this and #171 extending an existing ADR or does a new one need to be created?

@aricart
Copy link
Member Author

aricart commented Nov 23, 2022

@aricart No urgency, but is this and #171 extending an existing ADR or does a new one need to be created?

@bruth there's no ADR - this is just a connect option to prevent the default client behaviour.

@bruth
Copy link
Member

bruth commented Nov 23, 2022

Ok thanks, that is what I assumed. I am in the process of evolving some PR templates to help differentiate the kinds of issues that are created in this repo.

@scottf scottf assigned levb and unassigned ColinSullivan1 Mar 21, 2023
@ripienaar ripienaar removed their assignment Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Client related work enhancement New feature or request
Projects
None yet
Development

No branches or pull requests