Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow style function to test CSS variables #55

Merged
merged 2 commits into from Nov 27, 2021
Merged

Allow style function to test CSS variables #55

merged 2 commits into from Nov 27, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 23, 2021

Indexing a computed style does not allow to read CSS variables. Using getPropertyValue allows to get "normal" CSS properties as well as variables.

Furthermore the value of the property is not trimmed, since we had some tests fail due to the properties being [whitespace]#123456. The whitespace makes no functional difference to CSS but found that they are undesirable to include in the testing logic.

Thank you for your time!

@nathanboktae nathanboktae merged commit 94a3bf7 into nathanboktae:master Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant