{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":683003056,"defaultBranch":"master","name":"gephi","ownerLogin":"nathanal","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-08-25T11:15:31.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/22120290?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1693373647.0","currentOid":""},"activityList":{"items":[{"before":"5a78f1732b6543a48833a992ac27317c79c92256","after":"2d3ebe634a4e4dd646a55654549cbfd25b44fa3b","ref":"refs/heads/github2842","pushedAt":"2023-09-21T11:05:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Don't draw invalid svg paths for curved edges (#2842)\n\n- Don't draw edge when completely truncated.\n- computeThatThing condition previously never failed as rt is negative\n- Pass arc angle to computeThatThing for extra precision\n- Return large negative value so we know edge is totally truncated\n- Don't reposition edge labels when edge totally truncated\n- Add edge label edge case for two nodes in the same position\n- Don't change angle of arrow if edge totally truncated (avoid NaN in polyline)\n- Add \"unit\" test for svg export of edge cases.\n  Added to PreviewExport, not PreviewPlugin, to avoid relying\n  on details of plugin set up. Downside: pdf isn't easily tested\n  as exceptions are caught too early.","shortMessageHtmlLink":"Don't draw invalid svg paths for curved edges (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1852759967\" data-permission-text=\"Title is private\" data-url=\"https://github.com/gephi/gephi/issues/2842\" data-hovercard-type=\"issue\" data-hovercard-url=\"/gephi/gephi/issues/2842/hovercard\" href=\"https://github.com/gephi/gephi/issues/2842\">gephi#2842</a>)"}},{"before":"90501dfc4492c562e3b127ae6a67fcb48cbd9458","after":"5a78f1732b6543a48833a992ac27317c79c92256","ref":"refs/heads/github2842","pushedAt":"2023-09-04T13:09:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Minor improvements to test\n\n- cleanup/improve comments\n- remove duplicated line\n- flip direction nodes are added in\n- curPos -> lowest to reflect what the variable is","shortMessageHtmlLink":"Minor improvements to test"}},{"before":"e0aa5199cb3856ec640a84f50e6c5ada35c5858a","after":"90501dfc4492c562e3b127ae6a67fcb48cbd9458","ref":"refs/heads/github2842","pushedAt":"2023-09-04T12:57:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Make it easier to extend test in the future\n\nBy avoiding hardcoding x/y values.\nAlso some checkstyle changes.","shortMessageHtmlLink":"Make it easier to extend test in the future"}},{"before":"0172b2b9e551e82c30a863b1410c725bb97e698d","after":"e0aa5199cb3856ec640a84f50e6c5ada35c5858a","ref":"refs/heads/github2842","pushedAt":"2023-09-04T12:14:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Add test for invalid numbers (NaN) in svg export\n\nAdded to PreviewExport instead of\nPreviewPlugin to avoid making the test too\ndependent on details required to set up\nthe plugin (preprocessing, etc.). Downside:\npdf isn't easily tested as the exception is caught\nbetween PreviewExport and PreviewPlugin.","shortMessageHtmlLink":"Add test for invalid numbers (NaN) in svg export"}},{"before":"c3213708f4037184acced2eb498a0a6a24b2930f","after":"6a466bea3eadf4afc79257d4618b99fa9736f359","ref":"refs/heads/github2813","pushedAt":"2023-09-02T15:28:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Improve preview, svg/pdf export of node's label's box (#2813)\n\n- Remove text outline's fill (avoids doubling text fill) (svg)\n- Boxes no longer have solid fill, but are stroked (svg, pdf)\n- Boxes, labels use transparency (svg)\n- Non-zero outline size no longer affects box stroke (preview)\n- Fix first box size by setting an explicit stroke (preview)\n- Box has consistent sharp corners (preview)\n- Box size accounts for outline size (all)\n- Box size includes descenders (y,g,p, etc) (pdf)\n- Box matches label position and looks roughly centered (svg)\n  dominant-baseline is unsupported by batik at the moment:\n  https://xmlgraphics.apache.org/batik/status.html","shortMessageHtmlLink":"Improve preview, svg/pdf export of node's label's box (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1705858721\" data-permission-text=\"Title is private\" data-url=\"https://github.com/gephi/gephi/issues/2813\" data-hovercard-type=\"issue\" data-hovercard-url=\"/gephi/gephi/issues/2813/hovercard\" href=\"https://github.com/gephi/gephi/issues/2813\">gephi#2813</a>)"}},{"before":"016425de8a5e0964d820fb73b5e9609deeb6d531","after":"0172b2b9e551e82c30a863b1410c725bb97e698d","ref":"refs/heads/github2842","pushedAt":"2023-09-02T15:26:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Don't draw invalid edge label in svg export (curved edges)\n\nCopies over some logic from the EdgeRenderer changes\nto match. Also add case for edge between two different\nnodes in the same position, which leads to x=y=NaN.\n\nThis does not try to create more accurate text positioning\nwhen the edge is truncated. Like the arrow logic, does not\ntry to determine when the edge is actually fully truncated\n(v. the edge is technically truncated but the arrow *should*\nbe drawn as if the edge is curved).","shortMessageHtmlLink":"Don't draw invalid edge label in svg export (curved edges)"}},{"before":"01268b27f03af978ef72e7f8e6c3c94a587d7cf6","after":"c3213708f4037184acced2eb498a0a6a24b2930f","ref":"refs/heads/github2813","pushedAt":"2023-09-02T14:03:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Make PDF export of node label box larger than text\n\nPreviously would not include the descenders.","shortMessageHtmlLink":"Make PDF export of node label box larger than text"}},{"before":"fedfa4535c9e9020e52bbe57ad5549df6d4324e5","after":"01268b27f03af978ef72e7f8e6c3c94a587d7cf6","ref":"refs/heads/github2813","pushedAt":"2023-09-02T13:35:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Improve preview, svg/pdf export of node's label's box (#2813)\n\n- Remove text outline's fill (avoids doubling text fill) (svg)\n- Boxes no longer have solid fill, but are stroked (svg, pdf)\n- Boxes, labels use transparency (svg)\n- Non-zero outline size no longer affects box stroke (preview)\n- Fix first box size by setting an explicit stroke (preview)\n- Box has consistent sharp corners (preview)\n- Box size accounts for outline size (all)\n- Box matches label position and looks roughly centered (svg)\n  dominant-baseline is unsupported by batik at the moment:\n  https://xmlgraphics.apache.org/batik/status.html","shortMessageHtmlLink":"Improve preview, svg/pdf export of node's label's box (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1705858721\" data-permission-text=\"Title is private\" data-url=\"https://github.com/gephi/gephi/issues/2813\" data-hovercard-type=\"issue\" data-hovercard-url=\"/gephi/gephi/issues/2813/hovercard\" href=\"https://github.com/gephi/gephi/issues/2813\">gephi#2813</a>)"}},{"before":"52d5ad386985f5c209f3f5f902bb716b1ef72fd7","after":"fedfa4535c9e9020e52bbe57ad5549df6d4324e5","ref":"refs/heads/github2813","pushedAt":"2023-08-31T02:07:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Improve preview, svg/pdf export of node's label's box (#2813)\n\n- Remove text outline's fill (avoids doubling text fill) (svg)\n- Boxes no longer have solid fill, but are stroked (svg, pdf)\n- Boxes, labels use transparency (svg)\n- Non-zero outline size no longer affects box stroke (preview)\n- Fix first box size by setting an explicit stroke (preview)\n- Box has consistent sharp corners (preview)\n- Box size accounts for outline size (all)\n- Box matches label position and looks roughly centered (svg)\n  dominant-baseline is unsupported by batik at the moment:\n  https://xmlgraphics.apache.org/batik/status.html","shortMessageHtmlLink":"Improve preview, svg/pdf export of node's label's box (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1705858721\" data-permission-text=\"Title is private\" data-url=\"https://github.com/gephi/gephi/issues/2813\" data-hovercard-type=\"issue\" data-hovercard-url=\"/gephi/gephi/issues/2813/hovercard\" href=\"https://github.com/gephi/gephi/issues/2813\">gephi#2813</a>)"}},{"before":"dd01a476e3d59079a904debb1e8d82828ec6cdd4","after":"016425de8a5e0964d820fb73b5e9609deeb6d531","ref":"refs/heads/github2842","pushedAt":"2023-08-31T02:04:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Don't draw invalid svg paths for curved edges\n\nFix svg output in #2842 (one node is inside another) by\nnot drawing the edge when it is truncated too much.\n\nPreviously, computeThatThing's condition never failed, as\nrt was only passed when negative. We now pass the arc length\nand return a large negative angle if it fails. This should\nregister as excessive truncating and be marked not to be drawn.","shortMessageHtmlLink":"Don't draw invalid svg paths for curved edges"}},{"before":"be888a06edbde99b68640dd6217c7c2b3bf0b708","after":"dd01a476e3d59079a904debb1e8d82828ec6cdd4","ref":"refs/heads/github2842","pushedAt":"2023-08-31T01:45:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Don't draw invalid svg paths for curved edges\n\nFix svg output in #2842 (one node is inside another) by\nnot drawing the edge when it is truncated too much.\n\nPreviously, computeThatThing's condition never failed, as\nrt was only passed when negative. We now pass the arc length\nand return a large negative angle if it fails. This should\nregister as excessive truncating and be marked not to be drawn.","shortMessageHtmlLink":"Don't draw invalid svg paths for curved edges"}},{"before":null,"after":"52d5ad386985f5c209f3f5f902bb716b1ef72fd7","ref":"refs/heads/github2813","pushedAt":"2023-08-30T05:34:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Improve preview, svg/pdf export of node's label's box (#2813)\n\n- Remove text outline's fill (avoids doubling text fill) (svg)\n- Boxes no longer have solid fill, but are stroked (svg, pdf)\n- Boxes, labels use transparency (svg)\n- Non-zero outline size no longer affects box stroke (preview)\n- Fix first box size by setting an explicit stroke (preview)\n- Box has consistent sharp corners (preview)\n- Box size accounts for outline size (all)\n- Box matches label position and looks roughly centered (svg)\n  dominant-baseline is unsupported by batik at the moment:\n  https://xmlgraphics.apache.org/batik/status.html","shortMessageHtmlLink":"Improve preview, svg/pdf export of node's label's box (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1705858721\" data-permission-text=\"Title is private\" data-url=\"https://github.com/gephi/gephi/issues/2813\" data-hovercard-type=\"issue\" data-hovercard-url=\"/gephi/gephi/issues/2813/hovercard\" href=\"https://github.com/gephi/gephi/issues/2813\">gephi#2813</a>)"}},{"before":"40b18ec7723d6657919b300cba31bbae3f42b56e","after":"be888a06edbde99b68640dd6217c7c2b3bf0b708","ref":"refs/heads/github2842","pushedAt":"2023-08-25T17:04:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Don't draw invalid svg paths for curved edges\n\nFix svg output in #2842 (one node is inside another) by\nnot drawing the edge when it is truncated too much.\n\nPreviously, computeThatThing's condition never failed, as\nrt was only passed when negative. We now pass the arc length\nand return a large negative angle if it fails. This should\nregister as excessive truncating and be marked not to be drawn.","shortMessageHtmlLink":"Don't draw invalid svg paths for curved edges"}},{"before":"11e728bcd562f046cec98bf0bf7361f1e6c1fab1","after":"40b18ec7723d6657919b300cba31bbae3f42b56e","ref":"refs/heads/github2842","pushedAt":"2023-08-25T16:59:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Don't draw invalid svg paths for curved edges\n\nFix svg output in #2842 (one node is inside another) by\nnot drawing the edge when it is truncated too much.\n\nPreviously, computeThatThing's condition never failed, as\nrt was only passed when negative. We now pass the arc length\nand return a large negative angle if it fails. This should\nregister as excessive truncative and be marked not to be drawn.","shortMessageHtmlLink":"Don't draw invalid svg paths for curved edges"}},{"before":"a75be6bd7550993ca83cccc43b4e7b3e465220b3","after":"11e728bcd562f046cec98bf0bf7361f1e6c1fab1","ref":"refs/heads/github2842","pushedAt":"2023-08-25T16:21:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Don't draw invalid svg paths for curved edges\n\nFix svg output in #2842 (one node is inside another) by\nnot drawing the edge when it is truncated too much.\n\nPreviously, computeThatThing's condition never failed, as\nrt was only passed when negative. We now pass the arc length\nand return a large negative angle if it fails. This should\nregister as excessive truncative and be marked not to be drawn.","shortMessageHtmlLink":"Don't draw invalid svg paths for curved edges"}},{"before":null,"after":"a75be6bd7550993ca83cccc43b4e7b3e465220b3","ref":"refs/heads/github2842","pushedAt":"2023-08-25T11:29:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"nathanal","name":null,"path":"/nathanal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22120290?s=80&v=4"},"commit":{"message":"Don't draw invalid curved edges in corner case\n\nFix svg output in #2842 (one node is inside another) by\nnot drawing an edge. The arrow is drawn as if a straight\nedge was drawn.\n\nPreviously, computeThatThing's conditional never failed,\nrt was only passed when negative. We now pass length\n(between the node centers), as it  appears to be the\nreal limit, not the arc's radius.","shortMessageHtmlLink":"Don't draw invalid curved edges in corner case"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADhaUXVwA","startCursor":null,"endCursor":null}},"title":"Activity · nathanal/gephi"}