From 130cd5ced3f2d22fb1c777ab4d6c680267c82a50 Mon Sep 17 00:00:00 2001 From: Gerald Monaco Date: Mon, 7 Feb 2022 12:16:13 -0800 Subject: [PATCH] Stop exposing internal `render` and `renderError` methods from `next/client` (#34069) These should no longer need to be exposed. --- packages/next/client/index.tsx | 4 ++-- packages/next/client/next-dev.js | 4 +--- packages/next/client/next.js | 4 +--- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/next/client/index.tsx b/packages/next/client/index.tsx index 4bd285307154dea..bb88e23be4a5243 100644 --- a/packages/next/client/index.tsx +++ b/packages/next/client/index.tsx @@ -434,7 +434,7 @@ export async function initNext( render(renderCtx) } -export async function render(renderingProps: RenderRouteInfo): Promise { +async function render(renderingProps: RenderRouteInfo): Promise { if (renderingProps.err) { await renderError(renderingProps) return @@ -462,7 +462,7 @@ export async function render(renderingProps: RenderRouteInfo): Promise { // This method handles all runtime and debug errors. // 404 and 500 errors are special kind of errors // and they are still handle via the main render method. -export function renderError(renderErrorProps: RenderErrorProps): Promise { +function renderError(renderErrorProps: RenderErrorProps): Promise { const { App, err } = renderErrorProps // In development runtime errors are caught by our overlay diff --git a/packages/next/client/next-dev.js b/packages/next/client/next-dev.js index 8f1dad083d2f16a..65f2c08c6cc77fb 100644 --- a/packages/next/client/next-dev.js +++ b/packages/next/client/next-dev.js @@ -1,4 +1,4 @@ -import { initNext, version, router, emitter, render, renderError } from './' +import { initNext, version, router, emitter } from './' import initOnDemandEntries from './dev/on-demand-entries-client' import initWebpackHMR from './dev/webpack-hot-middleware-client' import initializeBuildWatcher from './dev/dev-build-watcher' @@ -44,8 +44,6 @@ window.next = { return router }, emitter, - render, - renderError, } initNext({ webpackHMR, beforeRender: displayContent }) .then(() => { diff --git a/packages/next/client/next.js b/packages/next/client/next.js index 8a0f8bad9e4a9b6..e17fdc100dd8f4e 100644 --- a/packages/next/client/next.js +++ b/packages/next/client/next.js @@ -1,4 +1,4 @@ -import { initNext, version, router, emitter, render, renderError } from './' +import { initNext, version, router, emitter } from './' window.next = { version, @@ -7,8 +7,6 @@ window.next = { return router }, emitter, - render, - renderError, } initNext().catch(console.error)