Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for private base type options #288

Merged

Conversation

Alxandr
Copy link
Contributor

@Alxandr Alxandr commented Oct 4, 2019

Resolves #287

@Alxandr Alxandr force-pushed the feat/private-base-type-option branch from 8d9e352 to a7ac630 Compare October 4, 2019 09:57
@natemcmaster
Copy link
Owner

Hey, just wanted to let you know I've seen this, but I haven't reviewed its contents. I hope to have free time in the next 7 days or so to take a closer look.

  • Nate

@natemcmaster natemcmaster merged commit b92f20e into natemcmaster:master Oct 12, 2019
@natemcmaster
Copy link
Owner

Thanks for the contribution! This will be in the next release - 2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private members in base classes are ignored
2 participants