Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time zone issue with log rotation #198

Open
wangkunn opened this issue Nov 19, 2023 · 0 comments
Open

Time zone issue with log rotation #198

wangkunn opened this issue Nov 19, 2023 · 0 comments

Comments

@wangkunn
Copy link

wangkunn commented Nov 19, 2023

Hi nate,
Thank you for your work in lumberjack!

When I used this library, I encountered the following problem:

When calculating whether an old log file has reached rotation time, the time zone is not taken into account for the processing of timestamps in log file names, even if localtime is set to true. This may cause the log rotation time to differ from MaxAge.

I have submitted a PR to solve this problem, please evaluate whether it can be accepted.
#197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant