Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle valid non-separator backslash characters in filepaths passed to expand_path #1479

Open
phargogh opened this issue Dec 14, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@phargogh
Copy link
Member

In expand_path (#1477), we are now checking for the existence of \ characters in filepaths provided to the function and, if we are on a linux/mac system, assuming that this is a windows path separator and converting \ to /.

Unfortunately, \ is a valid filepath character on linux/mac, so this is not a truly safe assumption to make. It would be safer to, when passed a filepath containing \, handle the possibility that one or more of the \ characters are valid path characters and return the correct, sanitized path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant