(馃巵) only use tomli in python<3.11 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotlinIsland
force-pushed
the
main
branch
2 times, most recently
from
4fba16a
to
b951e86
Compare
|
Hi @KotlinIsland, Thanks for the contribution and sorry for the unresponsiveness. I intend to deal with this properly but have not had a lot of time lately. Having one less dependency for python 3.11 is a nice outcome :). However it looks like the change to the conftest is causing problems. Maybe we should still use tomli as a dev dependency to avoid that issue? |
KotlinIsland
changed the title
KotlinIsland
changed the title
|
@KotlinIsland It looks like something is fishy the the CI environment. Rerunning the action on main:HEAD fails :( There's no reason to block this PR, so I've disable that test env for now, and will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.