Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tokio to v1.0.1 #154

Closed
mankinskin opened this issue Jan 10, 2021 · 4 comments
Closed

Upgrade tokio to v1.0.1 #154

mankinskin opened this issue Jan 10, 2021 · 4 comments

Comments

@mankinskin
Copy link
Contributor

Tokio 1.0 was just released and upgrading to it should be a good step towards more stable dependencies. This might also solve #57

@notonamap
Copy link
Contributor

Hey @mankinskin. just a small note that tokio 1 types currently don't implement Stream which openlimits relies upon in some parts of the code. I suggest to wait til tokio has it back in. https://docs.rs/tokio/1.0.1/tokio/stream/index.html

@mankinskin
Copy link
Contributor Author

Do we know how long that is going to take? Might be easier for other crates to use openlimits when it uses a recent version of tokio. The changes required by the missing Stream implementation on UnboundedReceiver was basically just replacing .next() with .recv() and replacing .poll_next_unpin() with Pin::new(&mut $self).poll_recv() (see nash-io/nash-rust#47).

I mean to say I think it would still be better to take the step forward and merge it. The Stream parts could easily be changed back when 1.0.1 lands.

@notonamap
Copy link
Contributor

I don't think it will be that easy for openlimits as it uses more future-rs stream based stuff. But sure you can try if you feel like it.. I'm not a maintainer of this repo though so you might want to coordinate with someone from the Nash crew like @notdanilo

@mankinskin
Copy link
Contributor Author

Hmm.. actually I just noticed I didn't depend on the updated version of nash-rust (with tokio-1.0) and there actually is some more code that requires Stream trait specifically.

Seems like you are right.

@mankinskin mankinskin changed the title Upgrade tokio to v1.0 Upgrade tokio to v1.0.1 Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants