Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Conditional Styling] Visibility option on Conditional Styling is broken #7718

Open
3 of 7 tasks
rukmini-bose opened this issue May 8, 2024 · 2 comments
Open
3 of 7 tasks
Assignees
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug

Comments

@rukmini-bose
Copy link
Contributor

rukmini-bose commented May 8, 2024

Summary

When you conditionally style widgets or images in a Display Layout, the option to toggle the visibility is broken.

bug.mov

Expected vs Current Behavior

The eye toggle in Conditional Styles allows for images to appear or disappear based on the condition.

Steps to Reproduce

  1. Download this JSON file that includes an example of the bug. DL .json
  2. This JSON has the following: a Display Layout that shows a Condition Set output, the telemetry's current value, and an image that uses the Condition Set. This image has the conditional styling logic such that when the Condition Set outputs the string "invisible", the image disappears. When the Condition Set outputs the string "visible", the image appears.
  3. Observe that when the Condition Set outputs "Invisible", the NASA logo does not disappear as it should.

Environment

  • Open MCT Version: 4.0.0 next
  • Deployment Type: All
  • OS:
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@rukmini-bose rukmini-bose added the bug:regression It used to work. Now it doesn't :( label May 9, 2024
@charlesh88
Copy link
Contributor

If this breaks any existing mission operations displays, then I'll argue strenuously that this is a blocker.

@ozyx
Copy link
Member

ozyx commented May 9, 2024

If this breaks any existing mission operations displays, then I'll argue strenuously that this is a blocker.

Important caveat I discovered in my testing. This seems to only apply to images. And I've only tested with png format so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug
Projects
None yet
Development

No branches or pull requests

3 participants