Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time List] Expanded Mode does not handle small horizontal spaces well #7696

Open
3 of 7 tasks
rukmini-bose opened this issue Apr 16, 2024 · 0 comments
Open
3 of 7 tasks
Assignees
Labels
bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue severity:medium type:bug

Comments

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Apr 16, 2024

Summary

When a Time List is in a Display or Flexible Layout, and the horizontal space is small enough, the components begin to spill out of the frame, causing all the elements to stop lining up correctly. Referencing the image below, notice that the countdowns are spilling out of the Time List wrapper, and that users would have to horizontally scroll to see its entire contents. Also, this is causing the state icons (such as the clock visualization) to stop being lined up.
Screenshot 2024-04-16 at 3 12 53 PM

From an initial investigation, it looks like this is because the countdown element doesn't wrap properly. Additionally, the class that holds the time bounds (.c-tli__bounds) has a dynamic width that is calculated based off its own event. So each of these classes end up having different widths, causing the elements to stop lining up.

This might be a regression, but its hard to say. There's been minimal testing of the new SA tool in layouts.

Expected vs Current Behavior

When a Time List view has a small horizontal space, we should have the components either wrap down or be truncated. We should also probably add a maximum width to the wrappers that hold the components together to maintain a consistent layout.

Steps to Reproduce

  1. Go to or create a Time List and ensure it is in Expanded mode.
  2. Drag this Time List into a Flexible Layout.
  3. Drag the Flexible Layout such that you make the Time List object very small in width.
  4. Observe that the countdown (right-most element) is spilling out of the Time List element. Also notice that components stop being lined up.

Environment

  • Open MCT Version: 4.0.0-next, VIPER 9.0.0-next
  • Deployment Type: /testathon
  • OS:
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@rukmini-bose rukmini-bose added bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue severity:medium type:bug
Projects
None yet
Development

No branches or pull requests

3 participants