Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for “Home – NAPI-RS” #37

Open
mogill opened this issue Jul 28, 2022 · 2 comments
Open

Feedback for “Home – NAPI-RS” #37

mogill opened this issue Jul 28, 2022 · 2 comments

Comments

@mogill
Copy link

mogill commented Jul 28, 2022

The README has a bullet point claiming "Zero copy data interactive between Rust & Node.js".
All data is copied into/out of the JS virtual machine by definition. Rust, like every other foreign interface, cannot directly access the JS heap without risking race conditions with garbage collection.
This claim should be removed or corrected.

@Brooooooklyn
Copy link
Sponsor Member

@mogill You can access ArrayBuffer/Buffer/TypedArray without data copy, and you can create them without data copy too.

@mogill
Copy link
Author

mogill commented Jul 29, 2022

That's what the website should say. The claim as written is deceitful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants