return join handle when spawning a tokio task #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need this to be able to safely drop an struct, that makes use of an async task. the drop function needs to be able to call `.abort()` on the join handle to avoid memory corruption and undefined bahviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr makes the spawn function return the join handle so it can be safely aborted when droping the object it is
spawned for.
Without this I need to run the future in a different tokio runtime instance to avoid a segfault:
deltachat/napi-jsonrpc@de56163
More info on the issue: deltachat/napi-jsonrpc#2
Basically I have an event receiving loop that is spawned when creating an account manager, but without this pr I'm not able to shutdown/abort the event loop safely resulting in a segfault when Nodejs garbage collects the object.