Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lambdas in help menu actions _help_actions.py #6744

Closed
lucyleeow opened this issue Mar 13, 2024 · 0 comments · Fixed by #6883
Closed

Remove lambdas in help menu actions _help_actions.py #6744

lucyleeow opened this issue Mar 13, 2024 · 0 comments · Fixed by #6883
Labels
maintenance PR with maintance changes,

Comments

@lucyleeow
Copy link
Contributor

We should remove lambdas used in help menu actions in napari/_app_model/actions/_help_actions.py.

The callbacks are all calls to webbrowser.open. This is a case where having kwargs field in actions would be useful. (ref: pyapp-kit/app-model#52)
@lucyleeow lucyleeow added the maintenance PR with maintance changes, label Mar 13, 2024
@lucyleeow lucyleeow changed the title Remove lambdas in help menu actions napari/_app_model/actions/_help_actions.py Remove lambdas in help menu actions _help_actions.py Mar 13, 2024
@lucyleeow lucyleeow mentioned this issue Mar 13, 2024
Open
21 tasks
@lucyleeow lucyleeow mentioned this issue May 2, 2024
Merged
@jni jni closed this as completed in #6883 May 20, 2024
jni pushed a commit that referenced this issue May 20, 2024
@lucyleeow
Move help actions under _qt and remove lambdas (#6883)
2102518 
# References and relevant issues
Closes #6744
Related:
#6848 (comment)

# Description
Move all help actions to `_qt/` and remove lambdas and replace with
partials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance PR with maintance changes,
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move help actions under _qt and remove lambdas lucyleeow/napari
1 participant
@lucyleeow