Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-bot] pip install --pre is failing #6871

Open
github-actions bot opened this issue Apr 25, 2024 · 0 comments
Open

[test-bot] pip install --pre is failing #6871

github-actions bot opened this issue Apr 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024

The --pre Test workflow failed on 2024-06-04 12:10 UTC

The most recent failing test was on windows-latest py3.12 pyqt5
with commit: f640234

Full run: https://github.com/napari/napari/actions/runs/9366746366

(This post will be updated if another test fails, as long as this issue remains open.)

@github-actions github-actions bot added the bug Something isn't working label Apr 25, 2024
andy-sweet added a commit that referenced this issue May 30, 2024
# References and relevant issues

Failure in our prerelease tests which picked up `numpy==2.0.0rc2`:
#6871 (comment)

Related discussion on Zulip:
https://napari.zulipchat.com/#narrow/stream/212875-general/topic/handling.20the.20numpy.202.2E0.20release

# Description
This fixes the coercion of data using the `Array` pydantic custom class
so that it works for both numpy 1 and 2, and only makes a copy if
needed.

Instead we could consider using `np.asarray`, but we'll also need to
replace the `ndmin` argument (which `np.asarray` does not have), by
using `np.expand_dims` or similar. I have done that it in one other
place where I don't need those fancy arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants