Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release of pyyaml 5.1 breaks how config.yml is loaded #611

Closed
tyler46 opened this issue Mar 14, 2019 · 2 comments
Closed

New release of pyyaml 5.1 breaks how config.yml is loaded #611

tyler46 opened this issue Mar 14, 2019 · 2 comments

Comments

@tyler46
Copy link
Contributor

tyler46 commented Mar 14, 2019 •
edited

hi :)

I think that new release of pyyaml has introduced some incompatible changes that perhaps cause an issue while installing nameko package. In particular based on nameko's setup.py it's required to install pyyaml>=3.10. That results installing latest version of pyyaml which has caused at least to me issues running nameko, because config.yml is not loaded correctly.
@gitricko
Copy link

yup... saw this today !

iky added a commit that referenced this issue Mar 15, 2019
@iky
Deal with latest pyyaml 5.1 security changes
35b3a8d 
#611
https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation
iky added a commit that referenced this issue Mar 15, 2019
@iky
Comply with pyyaml 5.1 security breaking changes
37a8936 
#611
https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation
@iky iky mentioned this issue Mar 15, 2019
Merged
@iky iky closed this as completed in #612 Mar 18, 2019
@tyler46
Copy link
Contributor Author

tyler46 commented Mar 18, 2019

thanks @iky !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tyler46 @gitricko