Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Xcode11 xcresult support #155

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Add Xcode11 xcresult support #155

merged 2 commits into from
Sep 17, 2019

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Sep 17, 2019 •
edited

Motivation

See 馃憠 fastlane-community/danger-xcov#26

Description

  • Updated :xccov_file_direct_path to accept .xcresult extension
  • Uses new https://github.com/fastlane-community/xcresult gem to parse .xcresult file and export the .xccovreport files to a destination directory when:
    • :xccov_file_direct_path is given and ends in .xcresult
    • no .xccoverage or .xccovreport files are found

To test

Update your Gemfile to 馃憞 and run bundle install or bundle update xcov

gem 'xcov`, :git => 'https://github.com/fastlane-community/xcov.git', :branch => 'joshdholtz-xcresult-support'

chrisballinger
chrisballinger approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@chrisballinger chrisballinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me on Xcode 11! After pointing to this fork in my Gemfile, no code or configuration changes were necessary for using xcov via fastlane, or for danger-xcov. Awesome work!!

Haven't tested that things aren't broken on Xcode 10 though.

@joshdholtz joshdholtz merged commit ac248a1 into master Sep 17, 2019
@joshdholtz joshdholtz deleted the joshdholtz-xcresult-support branch September 17, 2019 19:44
@FabienLydoire FabienLydoire mentioned this pull request Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisballinger chrisballinger chrisballinger approved these changes

@nakiostudio nakiostudio Awaiting requested review from nakiostudio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshdholtz @chrisballinger