Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow querying non-host python intepreters #128

Merged
merged 6 commits into from Sep 22, 2020

Conversation

gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Jul 24, 2020

This way you can install once (for example via pipx) and reuse it for any existing python environment.

$ pipdeptree --python venv/bin/python
pip==20.1.1
setuptools==49.2.0
wheel==0.34.2

@naiquevin for your attention. The CI fails because I cannot add the virtualenv dependency to Travis, it will only take effect post merge.

@gaborbernat gaborbernat force-pushed the master branch 2 times, most recently from 5f3932a to 5ff8e8d Compare July 24, 2020 16:03
@gaborbernat
Copy link
Member Author

@naiquevin can you take a look at this please?

@naiquevin
Copy link
Contributor

naiquevin commented Aug 4, 2020 via email

pipdeptree.py Outdated Show resolved Hide resolved
@naiquevin
Copy link
Contributor

@gaborbernat: That's a clever approach. This fixes a long pending feature request. Thanks a lot!

The code LGTM, but I've added a minor comment.

Also, can you please check the travis failure? It seems to be related to virtualenv version. Possibly related: Issue for travis to support specific virtualenv versions - travis-ci/travis-ci#8342

@naiquevin
Copy link
Contributor

naiquevin commented Sep 21, 2020

Another minor concern - It's possible that the main pipdeptree process is run using Python 3 but the specified Python interpreter is of version 2. This is not a problem as long as pipdeptree has compatibility with both Python versions (which is the case currently but can't be guaranteed in future). May be there should be a warning/recommendation regarding this in the README.

@gaborbernat
Copy link
Member Author

gaborbernat commented Sep 21, 2020

Another minor concern - It's possible that the main pipdeptree process is run using Python 3 but the specified Python interpreter is of version 2. This is not a problem as long as pipdeptree has compatibility with both Python versions (which is the case currently but can't be guaranteed in future). May be there should be a warning/recommendation regarding this in the README.

IMHO we should add that warning when we drop the python 2 support.

@gaborbernat
Copy link
Member Author

@naiquevin Travis is ignoring our install commands fro some odd reason, so moved to Github Actions within #133 to fix it

@gaborbernat
Copy link
Member Author

Added a commit to fix the --python= format.

@naiquevin
Copy link
Contributor

LGTM. Please rebase.

This way you can install once (for example via pipx) and reuse it for any
existing python environment.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
Copy link
Member Author

@naiquevin rebased, and fixed tests that were failing 👍 should be ready for merge.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
Copy link
Member Author

@naiquevin should be good to go now.

@naiquevin naiquevin merged commit e01462c into tox-dev:master Sep 22, 2020
@naiquevin
Copy link
Contributor

Thanks 👍

@gaborbernat
Copy link
Member Author

@naiquevin can we get a new release?

@naiquevin
Copy link
Contributor

Yeah, a release is long pending. I'll try to find some time in the coming week.

@gaborbernat
Copy link
Member Author

@naiquevin Hello any updates, thanks!

@naiquevin
Copy link
Contributor

naiquevin commented Dec 23, 2020 via email

@gaborbernat
Copy link
Member Author

Thanks that would be much appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants