New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow querying non-host python intepreters #128
Conversation
5f3932a
to
5ff8e8d
Compare
@naiquevin can you take a look at this please? |
Hi Bernát,
Sorry for the delay. Will try to check this PR sometime next week. A bit
caught up with work at the moment.
Thanks.
On Tue, 4 Aug 2020 at 8:52 PM, Bernát Gábor ***@***.***> wrote:
@naiquevin <https://github.com/naiquevin> can you take a look at this
please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#128 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEOZHBQRDAGYR6G3MZLZMDR7ARR3ANCNFSM4PGWVGCA>
.
--
~ Vineet
|
@gaborbernat: That's a clever approach. This fixes a long pending feature request. Thanks a lot! The code LGTM, but I've added a minor comment. Also, can you please check the travis failure? It seems to be related to virtualenv version. Possibly related: Issue for travis to support specific virtualenv versions - travis-ci/travis-ci#8342 |
Another minor concern - It's possible that the main pipdeptree process is run using Python 3 but the specified Python interpreter is of version 2. This is not a problem as long as pipdeptree has compatibility with both Python versions (which is the case currently but can't be guaranteed in future). May be there should be a warning/recommendation regarding this in the README. |
IMHO we should add that warning when we drop the python 2 support. |
b641c82
to
db2fa7e
Compare
@naiquevin Travis is ignoring our install commands fro some odd reason, so moved to Github Actions within #133 to fix it |
Added a commit to fix the |
LGTM. Please rebase. |
This way you can install once (for example via pipx) and reuse it for any existing python environment. Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@naiquevin rebased, and fixed tests that were failing 👍 should be ready for merge. |
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@naiquevin should be good to go now. |
Thanks 👍 |
@naiquevin can we get a new release? |
Yeah, a release is long pending. I'll try to find some time in the coming week. |
@naiquevin Hello any updates, thanks! |
I was planning to include a PR. But haven't been able to find the time. I
guess I'll proceed with creating a new version this weekend without the PR
…On Mon, Dec 21, 2020 at 9:28 PM Bernát Gábor ***@***.***> wrote:
@naiquevin <https://github.com/naiquevin> Hello any updates, thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#128 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEOZHFOPSJKRWF5WI5WVELSV5WCLANCNFSM4PGWVGCA>
.
--
~ Vineet
|
Thanks that would be much appreciated 👍 |
This way you can install once (for example via pipx) and reuse it for any existing python environment.
@naiquevin for your attention. The CI fails because I cannot add the virtualenv dependency to Travis, it will only take effect post merge.