Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .voters.yml optional #847

Open
foxted opened this issue Oct 14, 2023 · 2 comments
Open

Make .voters.yml optional #847

foxted opened this issue Oct 14, 2023 · 2 comments

Comments

@foxted
Copy link
Contributor

foxted commented Oct 14, 2023

For private repositories, in some instances, voting only requires the majority of contributors, no matter which contributors is voting.

I would suggest making the .voters.yml optional, and automatically assume a weight of 1 for each individual voter.

@myyk
Copy link
Owner

myyk commented Oct 16, 2023

This is a great suggestion and one I've heard before. I could imagine even making this the default in a v3 if people seem happy with it.

I'd be happy to accept a pull request that adds that, especially if the feature could have some testing for the functionality since maintenance is the most difficult part for this project.

It would also need some documentation updates to show how it works.

@myyk
Copy link
Owner

myyk commented Oct 16, 2023

Oh to clarify this, what were you thinking as the default group of voters? Is it from the approvers of the repo or something related to the org membership? Or some % of users that have ever contributed to the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants