Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can’t cut/split empty file creation into the first commit #55

Open
chris-morgan opened this issue Dec 6, 2019 · 1 comment
Open
Labels
design Needs feature design work enhancement New feature or request

Comments

@chris-morgan
Copy link
Contributor

When cutting a commit, it lets you choose which patches to include in the first commit, but it doesn’t show anything for empty files that are created, meaning that all empty file creations will end up in the second commit.

At least slightly related to #33 which is about binary changes always ending up in the second commit.

@mystor mystor added design Needs feature design work enhancement New feature or request labels Dec 9, 2019
@mystor
Copy link
Owner

mystor commented Dec 9, 2019

Thanks for the report! I agree that this is a similar situation to #33, caused by limitations of git reset --patch, which is used to show the hunk picker.
This should be fixable by providing our own interface for selecting which commit these non-patch files end up in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Needs feature design work enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants