Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-rewrite hook is not called #106

Open
arxanas opened this issue Oct 13, 2021 · 1 comment
Open

post-rewrite hook is not called #106

arxanas opened this issue Oct 13, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@arxanas
Copy link

arxanas commented Oct 13, 2021

This is mentioned in #35 (comment), but I thought I would raise a specific issue for this.

This causes git-revise to not interoperate well with git-branchless, because the latter expects post-rewrite to be called after rewrite operations to update its internal view of the commit graph. The result is that the pre-rewrite and post-rewrite commits both appear in git smartlog and related tooling. I mentioned this issue here: https://blog.waleedkhan.name/in-memory-rebases/#interactive-rebase

@mystor mystor added the enhancement New feature or request label Dec 23, 2021
@arxanas
Copy link
Author

arxanas commented Mar 26, 2022

Likewise, the reference-transaction hook is not called, although I'm not quite sure if git-revise moves branches. There is a good discussion of the circumstances under which various hooks should be called here: gitext-rs/git-stack#192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants