- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 176
Feat: no-deprecated-api
adheres to targeted node version
#164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: no-deprecated-api
adheres to targeted node version
#164
Conversation
@mysticatea, Few questions:
|
Thank you for this PR. But the current direction is different from I thought. This should change only error messages to hide unusable alternatives. The change affects only how it shows
No, I don't think this change needs document update. But updates are welcome because I'm poor at English :)
No. Because I will use "squash and merge" button to merge PRs, I don't mind about the number of commits.
No. The runtime version is different from the versions that the program supports. Currently the default value is |
@mysticatea I believe I understand what you are going for and I have updated the code. I hope you don't mind that I force pushed. I also hope I got the correct supported versions for the different replacements. As far as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, thank you very much!
I have a small suggestion.
@mysticatea Did you see my reply to your code comment? |
I'm sorry for my delay. ...OK, fair enough. I will merge this PR later. Thank you very much! |
Thank you very much for your contribution! |
I'm not sure this is working, I have a project with is configured with: "engines": {
"node": ">=6"
} But I still get:
|
Reproduction repository: https://github.com/julien-f/eslint-node-issue-141 |
@julien-f in my opinion, it is working as intended. You specified that a node supported version range of greater than or equal to 6.0.0 which would include 11.0.0. Hence the notification that the api in question is deprecated since 11.0.0. Further, Node recommends replacing ‘url.parse’ with the WHATWG URL API which is available as of 6.13.0. |
I disagree, it should not recommend an API that is not supported by a Node version compatible with my package (in this case This is exactly what is described in #141. Edit: even if that's 6.13.0, it's not compatible for all the versions covered by |
Patterned after
no-unsupported-features
Resolves #141.