Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: support the new rule meta.type property (fixes #143) #145

Merged
merged 1 commit into from Dec 8, 2018

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Dec 4, 2018

thoughts on the types?

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          64       64           
  Lines        1123     1123           
=======================================
  Hits         1103     1103           
  Misses         20       20
Impacted Files Coverage Δ
lib/rules/no-unpublished-bin.js 92.85% <ø> (ø) ⬆️
lib/rules/no-missing-require.js 100% <ø> (ø) ⬆️
lib/rules/prefer-global/url-search-params.js 100% <ø> (ø) ⬆️
lib/rules/prefer-global/console.js 100% <ø> (ø) ⬆️
lib/rules/shebang.js 97.56% <ø> (ø) ⬆️
lib/rules/prefer-global/buffer.js 100% <ø> (ø) ⬆️
lib/rules/no-unsupported-features/node-builtins.js 100% <ø> (ø) ⬆️
lib/rules/no-unpublished-import.js 100% <ø> (ø) ⬆️
lib/rules/no-deprecated-api.js 100% <ø> (ø) ⬆️
lib/rules/prefer-global/text-decoder.js 100% <ø> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932836b...43476c6. Read the comment docs.

Copy link
Owner

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants