Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zerolog version to 1.31.0 #5878

Closed
ScruffyPants opened this issue Oct 5, 2023 · 0 comments · Fixed by #5879
Closed

Bump zerolog version to 1.31.0 #5878

ScruffyPants opened this issue Oct 5, 2023 · 0 comments · Fixed by #5879
Assignees
Labels
dependencies Pull requests that update a dependency file Orange Team

Comments

@ScruffyPants
Copy link
Contributor

zerolog has been updated quite a few times in last years, however, the version for node at the time of writing this is v1.26.1. In v1.28.0 there exists a change, which, for node's implementation could be considered a breaking change (The change can be viewed here: rs/zerolog#457). This makes it problematic to use zerolog in new services/packages and then combine node with them as node is unable to compile with newer zerolog versions.

Solution:

  1. Bump zerolog versiong to 1.31.0 (latest at the time of writing this)
  2. Fix broken code.
@ScruffyPants ScruffyPants added dependencies Pull requests that update a dependency file Orange Team labels Oct 5, 2023
@ScruffyPants ScruffyPants self-assigned this Oct 5, 2023
@ScruffyPants ScruffyPants linked a pull request Oct 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Orange Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant