Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating URL parsing to WHATWG URL #2563

Open
dresende opened this issue Nov 20, 2023 · 2 comments · May be fixed by #2564
Open

Updating URL parsing to WHATWG URL #2563

dresende opened this issue Nov 20, 2023 · 2 comments · May be fixed by #2564
Assignees
@dresende
Labels
feature

Comments

@dresende
Copy link
Collaborator

dresende commented Nov 20, 2023 •
edited

@dougwilson I think we should update connection configuration URL parsing to use the new method as the previous is deprecated and I see some issues open about it (#2561), as well as myself hitting this problem with a more complex URL that url.parse is unable to process.

I can do this change right now but if we're going to do this, we should also increase the minimum node version that people can use with this module. What are your thoughts about it?
@dresende dresende self-assigned this Nov 20, 2023
@dougwilson
Copy link
Member

Oh, interesting. I mean, we could maybe use both, with the WHATWG when available, otherwise the old. What is the URL that you are having trouble with, BTW? Usually it is not very complex for this module, as there isn't a lot to it.

@dresende
Copy link
Collaborator Author

dresende commented Nov 21, 2023 •
edited

Ok, I will make a pull request supporting both. The URL has a password with a % on it. At first I tried to escape it, with no success using url.parse. The used the new URL approach and didn't even need to escape it. Just works.

@dresende dresende linked a pull request Nov 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dresende dresende

Labels
feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use WHATWG URL parsing, if available, instead of url.parse mysqljs/mysql
2 participants
@dougwilson @dresende