Updates for nodejs 10 compatibility. #2026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use setTimeout and .refresh if available. * Enable testing of nodejs 10.2.1. * Use 'tls.getCiphers()' if available to detect an available cipher for testing. Fixes #2003.
|
When is this version available? |
|
Sorry, something happened while I was waiting for a CI build on this, and didn't get back to it. Resuming work on this now. |
|
No worries, thanks for looking into this! |
|
Any news about this PR? |
|
@dougwilson Have you gotten any time to look at this? |
|
Yea, last night I finished up fixing a back compat edge case and so am heading home soon and plan to get it all up tonight. |
|
@dougwilson Any new issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing.
Fixes #2003.