Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Amazon RDS ca-central-1 CA #1809

Closed
wants to merge 3 commits into from
Closed

Conversation

CyranoB
Copy link
Contributor

@CyranoB CyranoB commented Aug 28, 2017

This adds Amazon RDS ca-central-1 CA to the embedded SSL profiles.

Copy link
Member

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new cert! Looks like the CI is failing because you may have accidentally overlooked the last step in https://github.com/mysqljs/mysql#contributing

I'll get your PR fixed up, but wanted to let you know in case you are able to get it fixed up before myself.

@CyranoB
Copy link
Contributor Author

CyranoB commented Aug 28, 2017 via email

@dougwilson dougwilson self-assigned this Aug 29, 2017
@dougwilson
Copy link
Member

Hi @CyranoB I'm not sure how the fingerprint was calculated in your PR, but I re-calculated it to properly match the given certificate.

@CyranoB
Copy link
Contributor Author

CyranoB commented Sep 5, 2017 via email

@dougwilson
Copy link
Member

Hi @CyranoB this PR was landed after a semver-minor landed in master, so it would not land until 2.15.0 (2.14.1 was already out prior to your pull request). There is an issue with the semver-minor change that had landed on master that is being worked out, delaying the 2.15.0 release. You can provide the CA string yourself in the meantime instead of using the Amazon RDS profile.

@CyranoB
Copy link
Contributor Author

CyranoB commented Oct 4, 2017

Hi @dougwilson Sorry to bother you again, but do you know when 2.15.0 will be released?

@dougwilson
Copy link
Member

I was waiting to hear back on #1811 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants