-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vanillajs-datepicker@1.2.0, breaks scss build, webpack 5, mini-css-extract-plugin #96
Comments
I think you use node-sass and migrating to dart sass should solve the problem. I did a test build using #87's setup with some modifications to use v1.2 and your webpack config, and was able compile successfully with only one warning from resolve-url-loader about source map configuration. It's been a while since node-sass became deprecated. I highly recommend switching to dart sass. |
i have the same problem. adding additional settings in webpack does not fix this problem
This solution does not work. Anyone else have any ideas ? package.json
|
When building a project on rails, I also encountered this problem. This error appeared after updating the version to 1.2.0
|
I blocked on package.json version that one |
I've just updated the change log. Since I have no intention to add backward compatibility for software already deprecated, that compile error will never be fixed through this library's update. |
For poeple who like to use v1.2 but have to stick with node-sass for some reason, If you don't use Bootstrap 5, you can do it with the following:
npm i -D vanillajs-datepicker@latest
npm i -D vanillajs-datepicker-11@mpm:vanillajs-datepicker@1.1.4
@import 'path/to/node_modules/vanillajs-datepicker-11/sass/datepicker'; In terms of style, there are no changes in v1.2.0. All the chages made on the stylesheets are adding bs5 stylesheet and update for dart sass syntax. Thus, unless your CSS framework is BS5, there should be no problem with using v1.1's stylesheet with v1.2's JS. |
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Invalid CSS after "...ize-base * math": expected expression (e.g. 1px, bold), was ".div(7, 8);"
on line 53 of node_modules/vanillajs-datepicker/sass/datepicker.scss
from line 69 of node_modules/vanillajs-datepicker/sass/datepicker-bulma.scss
from line 6 of src/index.scss
------------------------------------------^
webpack config:
The text was updated successfully, but these errors were encountered: