Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name option thorw an error #15

Closed
zoheirkhonyagar opened this issue Apr 16, 2020 · 4 comments
Closed

name option thorw an error #15

zoheirkhonyagar opened this issue Apr 16, 2020 · 4 comments

Comments

@zoheirkhonyagar
Copy link

when I run mongo-migrate new --name "my-name" I've got an error
Screenshot from 2020-04-16 12-43-44

@mycodeself
Copy link
Owner

You must not use quotes. Can you try without It and tell me if it works?

Thanks

@zoheirkhonyagar
Copy link
Author

zoheirkhonyagar commented Apr 16, 2020

yes, I tried but still I've got this error. it creates the migration file correctly. but just showed this error in the console.
I have some suggestions for this cool tool I'm very interested to contribute.
it would be awesome if we could up & down a specific migration just by name.

@zoheirkhonyagar
Copy link
Author

I checked and something was wrong with calling commander package

@mycodeself
Copy link
Owner

mycodeself commented Apr 18, 2020

I've been doing some research and found that the problem is with the latest version of commander lib tj/commander.js#1226

I've released a new version 1.0.9 that includes the fix and:

  • Fix new command with --name parameter by disable store options as properties in commander lib.
  • Add -n shortcut to new command.
  • Upgrade dependencies.

Now everything works, test it and tell me if you have any other problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants