Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the doc format from XDOC to Markdown #2691

Open
awxiaoxian2020 opened this issue Sep 12, 2022 · 6 comments
Open

Convert the doc format from XDOC to Markdown #2691

awxiaoxian2020 opened this issue Sep 12, 2022 · 6 comments

Comments

@awxiaoxian2020
Copy link
Contributor

awxiaoxian2020 commented Sep 12, 2022

Now, .md is more popular in GitHub. And some mybatis projects use it.
I think we can do something with it.

@xgl835
Copy link

xgl835 commented Sep 27, 2022

study follow you,thank you!

@awxiaoxian2020
Copy link
Contributor Author

@harawata I want to know whether the issue is valid or not. I want to work on it.

@harawata
Copy link
Member

Hello @awxiaoxian2020 ,

The obvious downside of the format change is that pull requests that contain doc changes require rework.
And there is an open PR #2586 which may require a lot of rework (we may not be able to merge it anytime soon).

Another possible/less-obvious downside is the review cost.
You may not know the answer to this, but when we compare the HTML files generated from .xdoc and .md using a diff tool, do they look the same?
If they look the same, it is fine, but if there are many differences, it will be a time consuming task to review the patch.

Also, this issue does not get any upvote so far.

So...
Although I personally prefer markdown over xdoc, I'm not sure if it's worth our time and effort (including yours) to convert the perfectly working .xdoc files, at this point.

@harawata harawata changed the title convert the docs from xml to md Convert the doc format from XDOC to Markdown Nov 27, 2022
@awxiaoxian2020
Copy link
Contributor Author

Hello @awxiaoxian2020 ,

The obvious downside of the format change is that pull requests that contain doc changes require rework. And there is an open PR #2586 which may require a lot of rework (we may not be able to merge it anytime soon).

Another possible/less-obvious downside is the review cost. You may not know the answer to this, but when we compare the HTML files generated from .xdoc and .md using a diff tool, do they look the same? If they look the same, it is fine, but if there are many differences, it will be a time consuming task to review the patch.

Also, this issue does not get any upvote so far.

So... Although I personally prefer markdown over xdoc, I'm not sure if it's worth our time and effort (including yours) to convert the perfectly working .xdoc files, at this point.

Sorry for late reply.

I will just change the style rather than the content. So I think it's not a problem for review. And we can work on this in a long period.

As the format of the document is more for developers than users, this issue has not received an upvote. So as long as you are willing to see the markdown format, I am willing to work on it.

#2586 I can also rework.

@harawata
Copy link
Member

harawata commented Dec 10, 2022

@awxiaoxian2020 ,

Okay.
As a trial run, could you convert just one file and send a PR?
Any file other than index.xml is fine.

It's not urgent, so please take your time.

Thank you!

@awxiaoxian2020
Copy link
Contributor Author

I will use https://github.com/awxiaoxian2020/html-markdown-util-for-mybatis-docs to get an init version. This will help
efficiency and accuracy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants