Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness to empty data in Plot and Nominal #3202

Merged
merged 2 commits into from
Dec 24, 2022
Merged

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Dec 23, 2022

Fixes #3186

With reprex from that issue:

@mwaskom mwaskom added this to the v0.12.2 milestone Dec 23, 2022
@mwaskom mwaskom changed the title Improve robustness to missing data in Plot and Nominal Improve robustness to empty data in Plot and Nominal Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #3202 (572030b) into master (26b3d0e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3202   +/-   ##
=======================================
  Coverage   98.41%   98.42%           
=======================================
  Files          76       76           
  Lines       24110    24115    +5     
=======================================
+ Hits        23729    23735    +6     
+ Misses        381      380    -1     
Impacted Files Coverage Δ
seaborn/_core/plot.py 99.33% <100.00%> (ø)
seaborn/_core/scales.py 90.09% <100.00%> (+0.23%) ⬆️
tests/_core/test_plot.py 98.68% <100.00%> (+<0.01%) ⬆️
tests/_core/test_scales.py 100.00% <100.00%> (ø)

@mwaskom mwaskom merged commit 87e0972 into master Dec 24, 2022
@mwaskom mwaskom deleted the fix/empty_facets branch December 24, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects interface raises if faceting on partially-crossed row and column
1 participant