Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log scaled histplot kde #3173

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Fix log scaled histplot kde #3173

merged 1 commit into from
Dec 4, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Dec 4, 2022

Fixes #3171

x = np.random.lognormal(0, 1, 1000)
ax = sns.histplot(x=x, log_scale=True, kde=True)

image

@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Merging #3173 (4cb58b7) into master (d4d27ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3173   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          76       76           
  Lines       24076    24082    +6     
=======================================
+ Hits        23695    23701    +6     
  Misses        381      381           
Impacted Files Coverage Δ
seaborn/distributions.py 96.35% <100.00%> (ø)
tests/test_distributions.py 99.80% <100.00%> (+<0.01%) ⬆️

@mwaskom mwaskom merged commit ba786bc into master Dec 4, 2022
@mwaskom mwaskom deleted the fix/log_kde_scaling branch December 4, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

histplot does not work well when using both kde and log_scale
1 participant